Migrate remaining logic from StartupFragment to compose and view models#3461
Merged
Conversation
This will be used in StartupFragment for showing progress dialog using compose
- Move startup initialization logic from `StartupFragment` to a new `StartupScreen` Composable. - Migrate error handling and progress dialog management from `StartupFragment` to `StartupViewModel` and `StartupScreen`. - Update `StartupViewModel` and `SignInViewModel` to use `@HiltViewModel` and remove manual bindings in `ViewModelModule`.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3461 +/- ##
============================================
+ Coverage 70.02% 70.07% +0.04%
- Complexity 1608 1613 +5
============================================
Files 320 322 +2
Lines 8598 8634 +36
Branches 946 951 +5
============================================
+ Hits 6021 6050 +29
- Misses 2003 2007 +4
- Partials 574 577 +3
🚀 New features to boost your workflow:
|
The change removes an unnecessary `LaunchedEffect` wrapper around the `onLoadFailed` callback when the `StartupScreen` is in an error state.
shobhitagarwal1612
requested review from
andreia-ferreira
and removed request for
anandwana001
andreia-ferreira
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1795
This PR aims to shift all non-Android logic, including screen generation, over to Jetpack Compose. This change is a step towards enabling Kotlin Multiplatform (KMP) support (as detailed in issue #3416) by removing the reliance on UI Views for iOS. While the long-term plan is to replace Fragments with Jetpack Navigation Compose, this specific PR focuses solely on the logic migration to Compose. The full switch to Navigation Compose will occur in a single update once every screen has been successfully migrated.
Verified that the functionality doesn't change by running the app locally. Also added test coverage for newly added compose screen and view models.
We've replaced the native progress dialog with a Jetpack Compose version, resulting in a slight visual change. Other screens will be updated to use this new dialog over time for consistency.
@andreia-ferreira @gino-m PTAL?